Transport Lines Manager -- Reborn!

[bornatoviski 1]

I think I could integrate IPT with TLM. It would be much easier.
The TLM would only have to adapt, integrate or customize the new dashboard that got cleaner. Sorry to be so suggestive is the vision of someone who works in the architecture and urbanism sector of the prefecture of Curitiba-PR Brazil

[Klyte45 173]

Good news: The TLM v6 was fixed and is working in the new version of the game.

Soon it will be back on Steam Workshop 

[bornatoviski 1]

Vou até agradece-lo em português Klyte45, um mod foda desses só podia ter a mão BR no meio

kkk

[rovapasi1 53]

Please have a look that the final version supports "service vehicle selector". Otherwise I always have to choose between using Airport Firetruck and sending out the proper cargo trains from a oil loading plattform OR using TLM.

[Klyte45 173]

1 hour ago, rovapasi1 said:

Please have a look that the final version supports "service vehicle selector". Otherwise I always have to choose between using Airport Firetruck and sending out the proper cargo trains from a oil loading plattform OR using TLM.

This adaptation shall be done on SVS. I can't do anything in TLM without broking it...

Anyway, TLM Reborn was released!

Added on 6.0:

• Support for mass transit
• Now shows external trains stations with a orange circle with a symbol (same model used for taxis, airports and ports)
• Now uses road names for bus and tram stations and line namings(if near a crossing, show name as Street A x Avenue B)
   

Known bugs:

• Rename depots are not working in the TLM listing and in depot details windows.
• Bus stations and terminals are wrongly listed as depots.
• Not show cable car stations on linear map as near transport
• IMPORTANT: the incomes of public transport stays at 0
• The depot list is not working.
• The label for "TLM_LIST_DEPOT_TOOLTIP" is missing
• There is another label for depots missing (FERRY_Config)

Next steps:

• Integrate IPT 2.
• ????

[boformer 3,169]

Why don't you update the original workshop item?

[Klyte45 173]

Because this is a new phase of TLM. May it change its name in a near future.
Also, who unsubscribed the old TLM will never get notified it came back. 

[rovapasi1 53]

Where to report bugs. Here or at the steam page?

[Klyte45 173]

I think here is better.

[rovapasi1 53]

OK. It does not break the game but still throws errors in mod tools.

1. The depot list is not working.

2. The label for "TLM_LIST_DEPOT_TOOLTIP:0" is missing

3. There is another label for depots missing (FERRY_Config)

[Klyte45 173]

Noted and added to known bug list. 

@alborzka, what you think about put the latest release and current list of known bugs on first post?

Well, these internacionalization problems can be easily solved on GitHub. Can someone create the entries for the missing labels? The label which are missing appears on output.log as:
Error with TLM_TOGGLE_LINES_DEPOT_TOOLTIP:0: The id was not found in the localization files.

Just need to create them in the en.properties file to create a default behaviour fo this cases. Note the prefix TLM_ is ommited on these files (ie: the entry for TLM_TOGGLE_LINES_DEPOT_TOOLTIP shall be TOGGLE_LINES_DEPOT_TOOLTIP) 

I'm now solving the zeroed fares bug.

[alborzka 66]

5 minutes ago, Klyte45 said:

@alborzka, what you think about put the latest release and current list of known bugs on first post?

Added to the OP

[boformer 3,169]

1 hour ago, Klyte45 said:

Because this is a new phase of TLM. May it change its name in a near future.
Also, who unsubscribed the old TLM will never get notified it came back. 

Right, but there are still thousands of subscribers who are only playing the game occasionally. It is a bad idea to leave behind the old workshop item in a broken state.

[alborzka 66]

Updated en.properties on my fork (still a bit lost on how Github works lol)

[Sparks44 92]

11 minutes ago, boformer said:

Right, but there are still thousands of subscribers who are only playing the game occasionally. It is a bad idea to leave behind the old workshop item in a broken state.

Maybe he could update it with a custom error message that says 'This mod is deprecated, please unsubscribe, and sub to the new one.'?

[Klyte45 173]

It can be a way.

Anyway, the old mod isn't breaking anything, just have a phrase saying thatversion won't be updated anymore.

[Klyte45 173]

Version 6.0.1 released. 

• Fixed no fares bug.
• Fixed i18n missing. (thx alborzka)

[rovapasi1 53]

Still the depot list does not work. Here is the part of the output.log

 

ArgumentNullException: Argument cannot be null.
Parameter name: key
  at System.Collections.Generic.Dictionary`2[Klyte.TransportLinesManager.Extensors.VehicleAIExt.TransportSystemDefinition,System.Collections.Generic.Dictionary`2[System.UInt16,System.Collections.Generic.List`1[System.UInt32]]].ContainsKey (Klyte.TransportLinesManager.Extensors.VehicleAIExt.TransportSystemDefinition key) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.Extensors.BuildingAIExt.TLMDepotAI.getConfigForTransportType (Klyte.TransportLinesManager.Extensors.VehicleAIExt.TransportSystemDefinition tsd) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.Extensors.BuildingAIExt.TLMDepotAI.getPrefixesServedByDepot (UInt16 buildingID) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.LineList.TLMPublicTransportDepotInfo.RefreshData () [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.LineList.TLMPublicTransportDetailPanel.AddDepotToList (Int32 count, UInt16 buildingID, ColossalFramework.UI.UIComponent& component) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.LineList.TLMPublicTransportDetailPanel.RefreshLines () [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.LineList.TLMPublicTransportDetailPanel.OnTabChanged (ColossalFramework.UI.UIComponent c, Int32 idx) [0x00000] in <filename unknown>:0
  at (wrapper delegate-invoke) ColossalFramework.UI.PropertyChangedEventHandler`1<int>:invoke_void__this___UIComponent_int (ColossalFramework.UI.UIComponent,int)
  at ColossalFramework.UI.UITabstrip.OnSelectedIndexChanged () [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UITabstrip.SelectTabByIndex (Int32 value) [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UITabstrip.set_selectedIndex (Int32 value) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.LineList.TLMPublicTransportDetailPanel.SetActiveTab (Int32 idx) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.LineList.TLMPublicTransportDetailPanel.toggleDepotView () [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.LineList.TLMPublicTransportDetailPanel.<AwakeTopButtons>b__85_3 (ColossalFramework.UI.UIComponent component, ColossalFramework.UI.UIMouseEventParameter eventParam) [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIComponent.OnClick (ColossalFramework.UI.UIMouseEventParameter p) [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIButton.OnClick (ColossalFramework.UI.UIMouseEventParameter p) [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIComponent.OnClick (ColossalFramework.UI.UIMouseEventParameter p) [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIInput+MouseHandler.ProcessInput (IInputTranslator translator, Ray ray, ColossalFramework.UI.UIComponent component, Boolean retainFocusSetting) [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIInput.ProcessMouseInput () [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIInput.Update () [0x00000] in <filename unknown>:0
 
(Filename:  Line: -1)

 

[alborzka 66]

@rovapasi1 thanks for reporting! Can you confirm that the other two bugs (2. The label for "TLM_LIST_DEPOT_TOOLTIP:0" is missing, and 3. There is another label for depots missing (FERRY_Config)) have gone for you now? I'm the one that changed those last two, not sure about the Depot List not working but will try to look into it before @Klyte45 does

Edit: Wait, sorry, what do you mean by Depot List isn't working? When you click on the factory button, you then click on the bus / metro / etc buttons and it should show a list of depots for each transit type. It does for me, at least... I'm not a coding expert, but I'll take a look at your ouput log you posted and see what I can figure out.

Edit 2: @Klyte45 I made some changes re: depot list text here (not related to @rovapasi1 error I don't think), please confirm/approve: most recent rev

[rovapasi1 53]

1. The label isssues are gone.

2. The depot list is not showing up. It still shows the lines and throws the reported error.

 

EDIT: Btw. I'm using MOM.

EDIT2: It shows the correct labels for a depot list (Depot Name, Served Lines, ...) but the content is not changing. It still shows only the lines.

[Dezelles 24]

@Klyte45

I have a question:
In How the game calculates the line vehicles quantity?

You explain that the formula is:  OverallBudget x PrefixBudget x LineLength / VehiclesMaxGap = Vehicle Count

Where:
OverallBudget: the budget set on city budget panel.
PrefixBudget: It's the prefix budget setted in TLM's asterisk tab, budget tab.
LineLength: the line lenght, in meters.
VehiclesMaxGap: the max gap between two vehicles in the line with: 750m for Buses and Trams; 1000m for Metros, Ships and Airplanes; 1500m for Trains.

Is this formula and its parameters part of the base of the game or have you added parameters? If yes, which ones?

[alborzka 66]

@rovapasi1 that is odd because I just made a test line (I use MOM too) and it seems to function correctly for me (although the metro depot being listed as a station should be addressed in a future rev):

 

 

But, of course, we will investigate -- well, @Klyte45 hopefully will, since I'm not too much of an expert

[rovapasi1 53]

Thats how it looks for me

 

[rovapasi1 53]

Next issue. The Sort by "Color" button does not work.

EDIT: But when I switch to another network type and then switch back, the sorting for the "Color" button is correct.

 

 

Error log:

NullReferenceException: Object reference not set to an instance of an object
  at PublicTransportDetailPanel.CompareColor (ColossalFramework.UI.UIComponent left, ColossalFramework.UI.UIComponent right) [0x00000] in <filename unknown>:0
  at PublicTransportDetailPanel.Quicksort (IList`1 elements, Int32 left, Int32 right, System.Comparison`1 comp) [0x00000] in <filename unknown>:0
  at PublicTransportDetailPanel.Quicksort (IList`1 elements, System.Comparison`1 comp) [0x00000] in <filename unknown>:0
  at PublicTransportDetailPanel.QuicksortOrInverseQuicksort (IList`1 elements, System.Comparison`1 comp, System.Comparison`1 compInverse) [0x00000] in <filename unknown>:0
  at PublicTransportDetailPanel.SortByColor () [0x00000] in <filename unknown>:0
  at PublicTransportDetailPanel.OnColorSort () [0x00000] in <filename unknown>:0
  at PublicTransportDetailPanel.<Awake>m__0 (ColossalFramework.UI.UIComponent c, ColossalFramework.UI.UIMouseEventParameter r) [0x00000] in <filename unknown>:0
  at (wrapper delegate-invoke) ColossalFramework.UI.MouseEventHandler:invoke_void__this___UIComponent_UIMouseEventParameter (ColossalFramework.UI.UIComponent,ColossalFramework.UI.UIMouseEventParameter)
  at ColossalFramework.UI.UIComponent.OnClick (ColossalFramework.UI.UIMouseEventParameter p) [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIButton.OnClick (ColossalFramework.UI.UIMouseEventParameter p) [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIInput+MouseHandler.ProcessInput (IInputTranslator translator, Ray ray, ColossalFramework.UI.UIComponent component, Boolean retainFocusSetting) [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIInput.ProcessMouseInput () [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIInput.Update () [0x00000] in <filename unknown>:0
 

[Dezelles 24]

@rovapasi1

If I am not mistaken, there are no depots for trains...
What does it mean for metro or buses?

[alborzka 66]

@Dezelles yes, no depots for trains exist. Each station is a "depot".

@rovapasi1 that is very unusual re: depot issue! Just tested with a train line and it works fine for me, so I'm wondering what the bug could be; will be investigated. And yeah good call re: colour sorting not working, I noticed it was buggy in the old edition as well; noted and added to bug list.

[rovapasi1 53]

35 minutes ago, Dezelles said:

If I am not mistaken, there are no depots for trains...
What does it mean for metro or buses?

Same.

[pauliaxz 195]

On 2017-05-20 at 3:38 PM, alborzka said:

Sorry, I'm a bit confused by what this means? What is spawn time interval function?

This is what I was talking about:

 

Once timer comes to 0, new vehicle is allowed to spawn, but not all at once as in vanilla.

[rovapasi1 53]

Sorry, but the next issue appears.

I have build for a modular station a metro track. Now I can not open the station window. When clicking on the station the station window opnes shortly and closes immediately throwing folloing error message.

After that happend once, I can not open any train station window any more as they only appear shortly and then dissappear.

It was working with the old version.

 

 

ArgumentNullException: Argument cannot be null.
Parameter name: key
  at System.Collections.Generic.Dictionary`2[Klyte.TransportLinesManager.Extensors.VehicleAIExt.TransportSystemDefinition,System.Collections.Generic.Dictionary`2[System.UInt16,System.Collections.Generic.List`1[System.UInt32]]].ContainsKey (Klyte.TransportLinesManager.Extensors.VehicleAIExt.TransportSystemDefinition key) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.Extensors.BuildingAIExt.TLMDepotAI.getConfigForTransportType (Klyte.TransportLinesManager.Extensors.VehicleAIExt.TransportSystemDefinition tsd) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.Extensors.BuildingAIExt.TLMDepotAI.getPrefixesServedByDepot (UInt16 buildingID) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.TLMUtils.getPrefixesServedAbstract (UInt16 m_buildingID) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.TLMController.updateDepotEditShortcutButton (ColossalFramework.UI.UIPanel parent) [0x00000] in <filename unknown>:0
  at Klyte.TransportLinesManager.TLMController+<>c__DisplayClass32_0.<initNearLinesOnWorldInfoPanel>b__0 (ColossalFramework.UI.UIComponent component, Boolean value) [0x00000] in <filename unknown>:0
  at (wrapper delegate-invoke) ColossalFramework.UI.PropertyChangedEventHandler`1<bool>:invoke_void__this___UIComponent_bool (ColossalFramework.UI.UIComponent,bool)
  at ColossalFramework.UI.UIComponent.OnVisibilityChanged () [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIComponent.set_isVisible (Boolean value) [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIComponent.Hide () [0x00000] in <filename unknown>:0
  at ColossalFramework.UI.UIDynamicPanels.Hide (System.String panelName) [0x00000] in <filename unknown>:0
  at WorldInfoPanel.Hide () [0x00000] in <filename unknown>:0
  at WorldInfoPanel.LateUpdate () [0x00000] in <filename unknown>:0
 
(Filename:  Line: -1)

[Klyte45 173]

@rovapasi1 I will see this case. But ArgumentNullException: Argument cannot be null. in the method Dictionary.ContainsKey seems to be a case of one of your stations are not well configured as station. Anyway, a null exception is a thing which should not to happen and I will fix it for next version.
@pauliaxz How this time is configured in IPT? (per depot, per line...) I have an idea of implementation of it inside TLM

4 hours ago, Dezelles said:

@Klyte45

I have a question:
In How the game calculates the line vehicles quantity?

You explain that the formula is:  OverallBudget x PrefixBudget x LineLength / VehiclesMaxGap = Vehicle Count

Where:
OverallBudget: the budget set on city budget panel.
PrefixBudget: It's the prefix budget setted in TLM's asterisk tab, budget tab.
LineLength: the line lenght, in meters.
VehiclesMaxGap: the max gap between two vehicles in the line with: 750m for Buses and Trams; 1000m for Metros, Ships and Airplanes; 1500m for Trains.

Is this formula and its parameters part of the base of the game or have you added parameters? If yes, which ones?

The PrefixBudget was added on TLM at the prefix configuration panel. Each prefixes can have a different configuration, but the default is 1.
The others variables are from base game.